Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

transformations: stencil shape inference polish #3046

Merged
merged 7 commits into from
Aug 17, 2024

Conversation

PapyChacal
Copy link
Collaborator

@PapyChacal PapyChacal commented Aug 16, 2024

Just update stencil shape inference to cooperative (i.e, bailing not crashing everything) and order-independent (proper use of the worklist instead of application-order assumptions) patterns.

@PapyChacal PapyChacal added the transformations Changes or adds a transformatio label Aug 16, 2024
@PapyChacal PapyChacal requested a review from n-io August 16, 2024 12:39
@PapyChacal PapyChacal self-assigned this Aug 16, 2024
Copy link

codecov bot commented Aug 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.89%. Comparing base (b01afed) to head (a3233a7).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3046   +/-   ##
=======================================
  Coverage   89.88%   89.89%           
=======================================
  Files         415      415           
  Lines       52095    52120   +25     
  Branches     8047     8060   +13     
=======================================
+ Hits        46828    46852   +24     
  Misses       3976     3976           
- Partials     1291     1292    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@PapyChacal PapyChacal marked this pull request as ready for review August 16, 2024 13:03
@PapyChacal PapyChacal changed the base branch from emilien/update-value-type to main August 17, 2024 11:58
@PapyChacal
Copy link
Collaborator Author

PapyChacal commented Aug 17, 2024

Just ported the feature from:

In the stencil code for less friction.

@PapyChacal PapyChacal merged commit 5568380 into main Aug 17, 2024
9 checks passed
@PapyChacal PapyChacal deleted the emilien/shape-inference branch August 17, 2024 12:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
transformations Changes or adds a transformatio
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants