Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dialects: dmp: make strategies attributes and carry them in IR #3050

Merged
merged 13 commits into from
Aug 19, 2024

Conversation

PapyChacal
Copy link
Collaborator

@PapyChacal PapyChacal commented Aug 16, 2024

As of now, the decomposition strategies are dataclasses and the information to construct them is expected to match in multiple bits of the pipeline (actually fused in distribute-stencil, which happens to do shape inference too, but I'm trying to decouple things here)

So instead, define them as attributes, and make the initial distribution pass pop that attribute on the swaps. The swap shape inference then do not need extra information to carry on.

Teaser: I want this part to be just collaborating shape inference as in:

@PapyChacal PapyChacal added dialects Changes on the dialects transformations Changes or adds a transformatio labels Aug 16, 2024
@PapyChacal PapyChacal self-assigned this Aug 16, 2024
Copy link

codecov bot commented Aug 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.88%. Comparing base (f591b3b) to head (3b8dd64).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3050      +/-   ##
==========================================
+ Coverage   89.87%   89.88%   +0.01%     
==========================================
  Files         416      415       -1     
  Lines       52441    52426      -15     
  Branches     8115     8111       -4     
==========================================
- Hits        47130    47123       -7     
+ Misses       4006     3999       -7     
+ Partials     1305     1304       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@PapyChacal PapyChacal marked this pull request as ready for review August 16, 2024 15:31
@PapyChacal PapyChacal force-pushed the emilien/dmp-strategy branch from 7ad5e9d to d1e8a0e Compare August 17, 2024 11:45
@PapyChacal PapyChacal requested review from superlopuh and n-io August 19, 2024 08:35
@PapyChacal PapyChacal merged commit f9df366 into main Aug 19, 2024
10 checks passed
@PapyChacal PapyChacal deleted the emilien/dmp-strategy branch August 19, 2024 12:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dialects Changes on the dialects transformations Changes or adds a transformatio
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants