-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
dialects: dmp: make strategies attributes and carry them in IR #3050
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PapyChacal
added
dialects
Changes on the dialects
transformations
Changes or adds a transformatio
labels
Aug 16, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3050 +/- ##
==========================================
+ Coverage 89.87% 89.88% +0.01%
==========================================
Files 416 415 -1
Lines 52441 52426 -15
Branches 8115 8111 -4
==========================================
- Hits 47130 47123 -7
+ Misses 4006 3999 -7
+ Partials 1305 1304 -1 ☔ View full report in Codecov by Sentry. |
n-io
reviewed
Aug 16, 2024
superlopuh
reviewed
Aug 16, 2024
superlopuh
reviewed
Aug 16, 2024
superlopuh
reviewed
Aug 16, 2024
PapyChacal
force-pushed
the
emilien/dmp-strategy
branch
from
August 17, 2024 11:45
7ad5e9d
to
d1e8a0e
Compare
n-io
approved these changes
Aug 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As of now, the decomposition strategies are dataclasses and the information to construct them is expected to match in multiple bits of the pipeline (actually fused in
distribute-stencil
, which happens to do shape inference too, but I'm trying to decouple things here)So instead, define them as attributes, and make the initial distribution pass pop that attribute on the swaps. The swap shape inference then do not need extra information to carry on.
Teaser: I want this part to be just collaborating shape inference as in:
shape-inference
pass #3047