dialects: remove some stencil dead code. #3055
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PapyChacal
added
dialects
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3055 +/- ##
==========================================
+ Coverage 90.04% 90.07% +0.03%
==========================================
Files 446 446
Lines 56401 56365 -36
Branches 5417 5412 -5
==========================================
- Hits 50788 50773 -15
+ Misses 4183 4162 -21
Partials 1430 1430 ☔ View full report in Codecov by Sentry. |
PapyChacal
changed the title
n-io
reviewed
Aug 19, 2024
| @@ -628,13 +622,6 @@ def get_rank(self) -> int: | |||
| assert self.bounds is not None | |||
| return len(self.bounds.lb) | |||
|
|
|||
| def get_num_results(self) -> int: | |||
There was a problem hiding this comment.
This looks useful, why remove?
AntonLydike
approved these changes
Sep 3, 2024
|
What's the latest on this? |
|
Let's merge or close this? @AntonLydike @PapyChacal @n-io @dk949 |
|
I don't mind either way, whatever suits the current devs! |
|
Happy to see this merged. |
n-io
approved these changes
Oct 24, 2024
EdmundGoodman
pushed a commit
to EdmundGoodman/xdsl
that referenced
this pull request
Dec 6, 2024
Co-authored-by: Sasha Lopoukhine <superlopuh@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.