dependencies: fix numpy version for subprojects that depend on it #3062
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
superlopuh
added
bug
superlopuh
requested review from
compor,
zero9178,
AntonLydike,
alexarice,
georgebisbas,
math-fehr,
PapyChacal and
webmiche
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3062 +/- ##
=======================================
Coverage 89.88% 89.88%
=======================================
Files 416 416
Lines 52426 52427 +1
Branches 8110 8110
=======================================
+ Hits 47121 47122 +1
Misses 4000 4000
Partials 1305 1305 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Numpy changed something in their typing annotations and now our main is broken. We should probably move to something that locks our dependencies for our CI, in the meantime, this PR specifies a numpy version and fixes the type errors.