dialects: stencil: Allow loading and storing from a same field. #3071
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…he specific lowering assuming it.
PapyChacal
added
dialects
PapyChacal
changed the title
PapyChacal
commented
Aug 20, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3071 +/- ##
==========================================
- Coverage 89.90% 89.90% -0.01%
==========================================
Files 418 418
Lines 52913 52898 -15
Branches 8202 8200 -2
==========================================
- Hits 47571 47556 -15
Misses 4015 4015
Partials 1327 1327 ☔ View full report in Codecov by Sentry. |
|
|
||
| // CHECK: "stencil.store"(%2, %0) {"bounds" = #stencil.bounds<[0, 0, 0], [64, 64, 64]>} : (!stencil.temp<[0,64]x[0,64]x[0,64]xindex>, !stencil.field<[0,64]x[0,64]x[0,64]xindex>) -> () | ||
| // CHECK-NEXT: ^^^^^^^^^^^^^^^------------------------------------------------------------------------------------------------------------------------- | ||
| // CHECK-NEXT: | Error while applying pattern: Cannot lower directly if storing to the same field multiple times! Try running `stencil-bufferize` before. |
There was a problem hiding this comment.
so, we still keep this, as expected
There was a problem hiding this comment.
Kinda, as a transition; This is now only an error to try and use the old lowering on such a case!
So you can now express it without hacks, and in most cases lower it simply by first running stencil-bufferize
There was a problem hiding this comment.
(Where before, it was considered an error to just write it!)
georgebisbas
approved these changes
Aug 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that
stencil-bufferizecan deal with those cases, lift this restriction at the stencil dialect level.Keep the check in the specific old conversion patterns still assuming this property for least surprise. Point user to use
stencil-bufferize, which if successful makes those operations disappear.