Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dialects: (transform) Add structured match operation #3079

Merged
merged 4 commits into from
Aug 23, 2024

Conversation

JonasCrols
Copy link
Contributor

This PR adds the important operation of the structured match in the transform dialect.
The PR is opened as a draft as I have not been able to find out how to implement the interface-attribute. which should be of kind enum (https://mlir.llvm.org/docs/Dialects/Transform/#transformstructuredmatch-transformmatchop)
@superlopuh @jorendumoulin

Copy link

codecov bot commented Aug 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.88%. Comparing base (bd14181) to head (a04b7f3).
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3079      +/-   ##
==========================================
- Coverage   89.90%   89.88%   -0.03%     
==========================================
  Files         418      418              
  Lines       52902    52944      +42     
  Branches     8202     8213      +11     
==========================================
+ Hits        47562    47588      +26     
- Misses       4014     4026      +12     
- Partials     1326     1330       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@JonasCrols JonasCrols marked this pull request as draft August 21, 2024 15:34
@jorendumoulin
Copy link
Collaborator

I'll have a look at the intenums!

@JonasCrols
Copy link
Contributor Author

As discussed on zullip, we'll use IntegerAttr's instead of the proper Int32EnumAttributes. this means the PR is now ready for review

@JonasCrols JonasCrols marked this pull request as ready for review August 23, 2024 07:14
@superlopuh superlopuh added the dialects Changes on the dialects label Aug 23, 2024
@jorendumoulin jorendumoulin merged commit 98c9276 into xdslproject:main Aug 23, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dialects Changes on the dialects
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants