Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dialects: (stablehlo) Add support for returnOp #3085

Merged

Conversation

efferifick
Copy link
Contributor

@efferifick efferifick commented Aug 22, 2024

Add support for stablehlo.returnOp.

Note: this operation is not listed in the standard, but it is used by examples in the standard. See for example:

// %index: -1
// %result_branch0: [0, 0]
// %result_branch1: [1, 1]
%result0, %result1 = "stablehlo.case"(%index) ({
  "stablehlo.return"(%result_branch0, %result_branch0) : (tensor<2xi64>, tensor<2xi64>) -> ()
}, {
  "stablehlo.return"(%result_branch1, %result_branch1) : (tensor<2xi64>, tensor<2xi64>) -> ()
}) : (tensor<i32>) -> (tensor<2xi64>, tensor<2xi64>)
// %result0: [1, 1]
// %result1: [1, 1]

@efferifick efferifick force-pushed the eochoa/2024-08-22/stablehlo-return-op branch from 5e6dfc0 to e80dd66 Compare August 22, 2024 21:31
@efferifick efferifick marked this pull request as ready for review August 22, 2024 21:36
Copy link

codecov bot commented Aug 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.90%. Comparing base (04fcab7) to head (e80dd66).
Report is 5 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3085      +/-   ##
==========================================
- Coverage   89.90%   89.90%   -0.01%     
==========================================
  Files         418      418              
  Lines       52914    52922       +8     
  Branches     8204     8205       +1     
==========================================
+ Hits        47571    47578       +7     
- Misses       4017     4018       +1     
  Partials     1326     1326              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@superlopuh superlopuh self-requested a review August 23, 2024 10:04
@superlopuh superlopuh added the dialects Changes on the dialects label Aug 23, 2024
@superlopuh superlopuh merged commit 3e2ff75 into xdslproject:main Aug 23, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dialects Changes on the dialects
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants