dialects: (stablehlo) add stablehlo.precision #3089
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
superlopuh
requested review from
zero9178,
AntonLydike,
alexarice,
PapyChacal,
webmiche and
shreya-um
superlopuh
force-pushed
the
sasha/jax/precision
branch
from
3968a1d to
415cf11
Compare
alexarice
approved these changes
Aug 23, 2024
| XLA precision for an operand. Has backend specific meaning. | ||
| """ | ||
|
|
||
| DEFAULT = "DEFAULT" |
There was a problem hiding this comment.
I believe you could use auto() here
There was a problem hiding this comment.
For some reason it made the string lowercase and my test failed
There was a problem hiding this comment.
# | Expected default, HIGH, or HIGHEST.
There was a problem hiding this comment.
Yep, documentation seems to say that auto lowercases
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3089 +/- ##
=======================================
Coverage 89.87% 89.88%
=======================================
Files 418 418
Lines 52952 52959 +7
Branches 8214 8215 +1
=======================================
+ Hits 47593 47602 +9
+ Misses 4028 4027 -1
+ Partials 1331 1330 -1 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One of the attributes necessary to express dot products
CC @efferifick