dialects: (stablehlo) add stablehlo.dot #3090
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
superlopuh
requested review from
zero9178,
alexarice,
PapyChacal,
webmiche and
shreya-um
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3090 +/- ##
=======================================
Coverage 89.90% 89.90%
=======================================
Files 421 421
Lines 53264 53306 +42
Branches 8257 8263 +6
=======================================
+ Hits 47885 47927 +42
Misses 4041 4041
Partials 1338 1338 ☔ View full report in Codecov by Sentry. |
alexarice
reviewed
Aug 23, 2024
xdsl/dialects/stablehlo.py
Outdated
| with printer.in_angle_brackets(): | ||
| with printer.indented(): | ||
| printer.print_string("\nlhs_batching_dimensions = [") | ||
| printer.print_list( |
There was a problem hiding this comment.
Does directly printing the ArrayAttr not work here?
There was a problem hiding this comment.
It wants to print the types for each int, I'll look into a more elegant way of doing this
alexarice
approved these changes
Aug 29, 2024
| printer.print_string(f"\n{name} = [") | ||
| printer.print_list( | ||
| value.data, | ||
| lambda dim: printer.print_string(f"{dim.value.data}"), |
There was a problem hiding this comment.
Suggested change
| lambda dim: printer.print_string(f"{dim.value.data}"), | |
| lambda dim: printer.print(dim.value.data), |
There was a problem hiding this comment.
Can ignore this if you want
There was a problem hiding this comment.
I actually prefer print_string to print, which is unfortunately pretty slow right now
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the attribute used to specify along which dimensions the dot products happen.
CC @efferifick