Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dialects: (stablehlo) add stablehlo.token #3093

Merged

Conversation

efferifick
Copy link
Contributor

@efferifick efferifick commented Aug 24, 2024

Adds stablehlo.token type.

@efferifick efferifick force-pushed the eochoa/2024-08-24/token-type branch from 3cd9d19 to 9159235 Compare August 24, 2024 00:19
@efferifick efferifick force-pushed the eochoa/2024-08-24/token-type branch from 9159235 to 9c290de Compare August 24, 2024 00:20
@efferifick efferifick marked this pull request as ready for review August 24, 2024 00:27
@efferifick
Copy link
Contributor Author

I am not sure if stablehlo.token should be parametrized attribute. All TypeAttributes must be either ParametrizedAttribute or Data so I just picked one. Let me know if I should remove this restriction from TypeAttribute or if stablehlo.token is fine as ParametrizedAttribute.

@superlopuh superlopuh added the dialects Changes on the dialects label Aug 24, 2024
Copy link

codecov bot commented Aug 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.89%. Comparing base (b55fadc) to head (9c290de).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3093      +/-   ##
==========================================
- Coverage   89.89%   89.89%   -0.01%     
==========================================
  Files         417      417              
  Lines       52945    52948       +3     
  Branches     8214     8215       +1     
==========================================
+ Hits        47594    47595       +1     
- Misses       4022     4023       +1     
- Partials     1329     1330       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@superlopuh
Copy link
Member

This is perfect, you did the right thing!

@superlopuh superlopuh merged commit c5c77e2 into xdslproject:main Aug 24, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dialects Changes on the dialects
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants