Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dialects: (stablehlo) add stablehlo.case #3095

Merged
merged 1 commit into from
Aug 28, 2024

Conversation

efferifick
Copy link
Contributor

@efferifick efferifick commented Aug 25, 2024

Adds stablehlo.case

@efferifick efferifick force-pushed the eochoa/2024-08-24/case-op branch 2 times, most recently from 4668757 to 954c46c Compare August 25, 2024 01:57
@efferifick efferifick marked this pull request as ready for review August 25, 2024 01:58
@efferifick efferifick force-pushed the eochoa/2024-08-24/case-op branch from 954c46c to 2197cf9 Compare August 25, 2024 02:02
@efferifick
Copy link
Contributor Author

Noticed that multiple returns are printed differently in xdsl.

// CHECK: %0, %1 = "stablehlo.case"(%index) ({
%0:2 = "stablehlo.case"(%index) ({

Copy link

codecov bot commented Aug 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.89%. Comparing base (1e488d7) to head (ae5cad8).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3095   +/-   ##
=======================================
  Coverage   89.89%   89.89%           
=======================================
  Files         419      419           
  Lines       53017    53027   +10     
  Branches     8221     8222    +1     
=======================================
+ Hits        47660    47671   +11     
  Misses       4028     4028           
+ Partials     1329     1328    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@superlopuh superlopuh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good modulo suggested changes

@superlopuh superlopuh added the dialects Changes on the dialects label Aug 26, 2024
@efferifick efferifick force-pushed the eochoa/2024-08-24/case-op branch from 0972f49 to ae5cad8 Compare August 27, 2024 23:31
@efferifick efferifick requested a review from superlopuh August 27, 2024 23:40
@efferifick
Copy link
Contributor Author

@superlopuh fixed merge conflicts

@superlopuh superlopuh merged commit 69a1d05 into xdslproject:main Aug 28, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dialects Changes on the dialects
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants