Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

transformations: (csl-stencil-to-csl-wrapper) Generate symbol export and no memref.globals #3101

Merged
merged 8 commits into from
Aug 28, 2024

Conversation

n-io
Copy link
Collaborator

@n-io n-io commented Aug 27, 2024

No description provided.

@n-io n-io added the transformations Changes or adds a transformatio label Aug 27, 2024
@n-io n-io requested a review from dk949 August 27, 2024 13:10
@n-io n-io self-assigned this Aug 27, 2024
Copy link

codecov bot commented Aug 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.90%. Comparing base (a2ed14d) to head (3eb1085).
Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3101      +/-   ##
==========================================
- Coverage   89.91%   89.90%   -0.02%     
==========================================
  Files         419      420       +1     
  Lines       53070    53147      +77     
  Branches     8226     8241      +15     
==========================================
+ Hits        47718    47781      +63     
- Misses       4023     4036      +13     
- Partials     1329     1330       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@n-io n-io requested a review from dk949 August 27, 2024 20:58
Copy link
Collaborator

@dk949 dk949 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See #r1733265639 resolved

@n-io n-io requested a review from dk949 August 28, 2024 15:30
Copy link
Collaborator

@dk949 dk949 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All looks good

@n-io n-io merged commit ca76864 into main Aug 28, 2024
14 checks passed
@n-io n-io deleted the nicolai/csl-generate-symbol-export branch August 28, 2024 17:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
transformations Changes or adds a transformatio
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants