Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core: Implement speculability trait and helper. #3102

Merged
merged 5 commits into from
Aug 28, 2024

Conversation

PapyChacal
Copy link
Collaborator

It is way simpler than side effects, as an op is either speculatable or is not!

Similarly to what was decided on side effects, I only changed that MLIR has an extra return value signifying "recursively speculatable", where here it is handled by an implementation of the trait, rather than in user code.
This prevents some amount of ninja-coding in said user code, but also a lot of ninja headaches.

@PapyChacal PapyChacal added minor For minor PRs, easy and quick to review, quickly mergeable core xDSL core (ir, textual format, ...) labels Aug 27, 2024
@PapyChacal PapyChacal self-assigned this Aug 27, 2024
Copy link

codecov bot commented Aug 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.90%. Comparing base (d625084) to head (322a364).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3102   +/-   ##
=======================================
  Coverage   89.89%   89.90%           
=======================================
  Files         419      419           
  Lines       53034    53068   +34     
  Branches     8223     8226    +3     
=======================================
+ Hits        47677    47711   +34     
  Misses       4029     4029           
  Partials     1328     1328           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@PapyChacal PapyChacal marked this pull request as ready for review August 27, 2024 14:57
Copy link
Member

@superlopuh superlopuh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great! Seems like it's missing tests ;)

@PapyChacal PapyChacal requested a review from superlopuh August 28, 2024 10:33
@PapyChacal PapyChacal merged commit a3a68f7 into main Aug 28, 2024
14 checks passed
@PapyChacal PapyChacal deleted the emilien/speculatibility branch August 28, 2024 10:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core xDSL core (ir, textual format, ...) minor For minor PRs, easy and quick to review, quickly mergeable
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants