core: Implement speculability trait and helper. #3102
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is way simpler than side effects, as an op is either speculatable or is not!
Similarly to what was decided on side effects, I only changed that MLIR has an extra return value signifying "recursively speculatable", where here it is handled by an implementation of the trait, rather than in user code.
This prevents some amount of ninja-coding in said user code, but also a lot of ninja headaches.