transformations: from csl_wrapper to csl modules
#3107
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Created layout loops and added params
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3107 +/- ##
==========================================
+ Coverage 89.94% 89.97% +0.03%
==========================================
Files 425 426 +1
Lines 53571 53666 +95
Branches 8299 8310 +11
==========================================
+ Hits 48185 48288 +103
+ Misses 4044 4035 -9
- Partials 1342 1343 +1 ☔ View full report in Codecov by Sentry. |
Still doesn't verify though, `scf.for` needs fixing
n-io
reviewed
Aug 28, 2024
n-io
reviewed
Aug 28, 2024
* Add `scf.yield` to the end. * Remove `iter_args` * Use `i16` as the loop counter
dk949
changed the title
csl_wrapper to csl modules
dk949
changed the title
csl_wrapper to csl modulescsl_wrapper to csl modules
n-io
reviewed
Sep 2, 2024
| assert isa(yield_op := op.layout_module.block.last_op, csl_wrapper.YieldOp) | ||
| rewriter.erase_op(yield_op) | ||
|
|
||
| with ImplicitBuilder(module_block): |
There was a problem hiding this comment.
Suggested change
| with ImplicitBuilder(module_block): | |
| with ImplicitBuilder(module_block := Block()): |
Some of these can be inlined, also inner/outer loop block. The block arg types can be passed directly as params.
Both layout module and program module rewrites have been rolled into one, there is no change to the underlying logic (the `match_and_rewrite` just got renamed to `lower_layout_module` and `lower_program_module`). `csl_wrapper.module` is modified in place, hence no need for a cleanup pass.
Since program module depends on the yield op from the layout region, it needs to be extracted first.
n-io
approved these changes
Sep 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Transforming
csl_wrapperto the twocsl.modules