Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Param names were not correctly referenced in the printer #3108

Merged
merged 1 commit into from
Aug 29, 2024

Conversation

dk949
Copy link
Collaborator

@dk949 dk949 commented Aug 28, 2024

Previously param's were printed using their param_name, but referenced by the name hint of their ssa value. They are now referenced by the param_name

@dk949 dk949 added the backend Compiler backend in xDSL label Aug 28, 2024
@dk949 dk949 requested a review from n-io August 28, 2024 20:14
@dk949 dk949 self-assigned this Aug 28, 2024
Copy link

codecov bot commented Aug 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.90%. Comparing base (ca76864) to head (56f348e).
Report is 4 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3108   +/-   ##
=======================================
  Coverage   89.90%   89.90%           
=======================================
  Files         421      421           
  Lines       53264    53265    +1     
  Branches     8257     8257           
=======================================
+ Hits        47885    47886    +1     
  Misses       4041     4041           
  Partials     1338     1338           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dk949 dk949 merged commit 5df9200 into main Aug 29, 2024
14 checks passed
@dk949 dk949 deleted the david/csl-backend/param-fix branch August 29, 2024 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend Compiler backend in xDSL
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants