dialects: (stim) Add first annotation op #3115
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d files in one folder
Co-authored-by: Sasha Lopoukhine <superlopuh@gmail.com>
Co-authored-by: Sasha Lopoukhine <superlopuh@gmail.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3115 +/- ##
=======================================
Coverage 90.05% 90.06%
=======================================
Files 438 438
Lines 54931 54952 +21
Branches 8535 8536 +1
=======================================
+ Hits 49470 49491 +21
Misses 4071 4071
Partials 1390 1390 ☔ View full report in Codecov by Sentry. |
Clean up some of the parser implementation ie. use in_angle_brackets Co-authored-by: Sasha Lopoukhine <superlopuh@gmail.com>
…lproject/xdsl into kim/stim/first-annotation-op
superlopuh
approved these changes
Sep 15, 2024
emmau678
pushed a commit
that referenced
this pull request
Oct 8, 2024
Stim contains _Annotations_, which are lines of code that are not part of the operational semantics, but provide information that may be used for error-correction or other compiler analyses. In this dialect they are stored as attributes on other operations, but the annotation operations are kept to allow users to direct these within their code. This pr adds the first, which is a qubit coord op - indicating an assignment of a reference to a qubit to a physical coordinate. An array of these can also be attached to a stimcircuitop. --------- Co-authored-by: Emilien Bauer <papychacal@gmail.com> Co-authored-by: Sasha Lopoukhine <superlopuh@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stim contains Annotations, which are lines of code that are not part of the operational semantics, but provide information that may be used for error-correction or other compiler analyses.
In this dialect they are stored as attributes on other operations, but the annotation operations are kept to allow users to direct these within their code.
This pr adds the first, which is a qubit coord op - indicating an assignment of a reference to a qubit to a physical coordinate. An array of these can also be attached to a stimcircuitop.