Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dialects: (scf) Add parse/print to scf.if #3126

Merged
merged 1 commit into from
Sep 2, 2024
Merged

dialects: (scf) Add parse/print to scf.if #3126

merged 1 commit into from
Sep 2, 2024

Conversation

alexarice
Copy link
Collaborator

Adds custom parsing to some scf ops and fixes the relevant tests.

I noticed during this that scf.reduce is now quite different to upstream mlir, but didn't attempt to change this.

@alexarice
Copy link
Collaborator Author

The implementation of reduce seems to disagree with the fixed mlir commit too, so will likely have to revert that for now

@superlopuh
Copy link
Member

jsut scf.if would already be great as a standalone PR, will also fix #2544

@alexarice alexarice changed the title dialects: (scf) Add parse/print to scf ops dialects: (scf) Add parse/print to scf.if Sep 1, 2024
Copy link

codecov bot commented Sep 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.92%. Comparing base (30dcaa1) to head (79accaa).
Report is 10 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3126   +/-   ##
=======================================
  Coverage   89.91%   89.92%           
=======================================
  Files         425      425           
  Lines       53391    53446   +55     
  Branches     8268     8278   +10     
=======================================
+ Hits        48006    48060   +54     
+ Misses       4047     4045    -2     
- Partials     1338     1341    +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@alexarice alexarice merged commit 21ebae4 into main Sep 2, 2024
14 checks passed
@alexarice alexarice deleted the alexarice/scf branch September 2, 2024 08:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants