Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dialects: Add NoMemoryEffect trait in various LLVM and builtin ops #3127

Merged
merged 1 commit into from
Sep 1, 2024

Conversation

JosseVanDelm
Copy link
Collaborator

Some ops in builtin and llvm dialect have the NoMemoryEffect upstream,
but don't have this in xDSL yet, which means that they will always return False on is_side_effect_free even though they are completely side-effect-free.

I added all NoMemoryEffects to the current LLVM dialect and Builtin.

@JosseVanDelm JosseVanDelm added invalid This doesn't seem right dialects Changes on the dialects labels Sep 1, 2024
Copy link

codecov bot commented Sep 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.93%. Comparing base (62de833) to head (9786e8a).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3127   +/-   ##
=======================================
  Coverage   89.93%   89.93%           
=======================================
  Files         425      425           
  Lines       53515    53527   +12     
  Branches     8290     8290           
=======================================
+ Hits        48130    48142   +12     
  Misses       4044     4044           
  Partials     1341     1341           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@JosseVanDelm JosseVanDelm merged commit e4aec6c into main Sep 1, 2024
14 checks passed
@JosseVanDelm JosseVanDelm deleted the Josse/sprinkle-NoMemoryEffect branch September 1, 2024 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dialects Changes on the dialects invalid This doesn't seem right
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants