dialects: Add NoMemoryEffect trait in various LLVM and builtin ops #3127
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some ops in builtin and llvm dialect have the NoMemoryEffect upstream,
but don't have this in xDSL yet, which means that they will always return False on
is_side_effect_free
even though they are completely side-effect-free.I added all NoMemoryEffects to the current LLVM dialect and Builtin.