Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dialects: (cf) Custom Parsing and assert change #3132

Merged
merged 2 commits into from
Sep 3, 2024

Conversation

alexarice
Copy link
Collaborator

Adds custom parsing to control flow operations. I also changed the message of a cf.assert op to be an attribute instead of a property to agree with mlir, but can revert this if there was a good reason for it (/or split it into a separate pr).

@alexarice alexarice self-assigned this Sep 2, 2024
@alexarice alexarice added dialects Changes on the dialects testing PRs that modify tests labels Sep 2, 2024
Copy link

codecov bot commented Sep 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.97%. Comparing base (9c49c49) to head (4f0924f).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3132   +/-   ##
=======================================
  Coverage   89.97%   89.97%           
=======================================
  Files         426      426           
  Lines       53712    53715    +3     
  Branches     8320     8320           
=======================================
+ Hits        48326    48330    +4     
  Misses       4043     4043           
+ Partials     1343     1342    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@alexarice alexarice merged commit c71c6ab into main Sep 3, 2024
14 checks passed
@alexarice alexarice deleted the alexarice/cf-improvements branch September 3, 2024 08:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dialects Changes on the dialects testing PRs that modify tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants