Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dialects: (cf) add switch #3156

Merged
merged 8 commits into from
Sep 16, 2024
Merged

dialects: (cf) add switch #3156

merged 8 commits into from
Sep 16, 2024

Conversation

alexarice
Copy link
Collaborator

Adds cf.switch and simple test

@alexarice alexarice added dialects Changes on the dialects testing PRs that modify tests labels Sep 10, 2024
@alexarice alexarice self-assigned this Sep 10, 2024
Copy link

codecov bot commented Sep 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.02%. Comparing base (c4bcca3) to head (dc30d43).
Report is 16 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3156      +/-   ##
==========================================
+ Coverage   90.00%   90.02%   +0.01%     
==========================================
  Files         427      430       +3     
  Lines       53857    54119     +262     
  Branches     8344     8378      +34     
==========================================
+ Hits        48474    48720     +246     
- Misses       4036     4043       +7     
- Partials     1347     1356       +9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

xdsl/dialects/cf.py Outdated Show resolved Hide resolved
xdsl/dialects/cf.py Outdated Show resolved Hide resolved
xdsl/dialects/cf.py Outdated Show resolved Hide resolved
xdsl/dialects/cf.py Outdated Show resolved Hide resolved
alexarice and others added 3 commits September 16, 2024 11:39
Co-authored-by: Sasha Lopoukhine <superlopuh@gmail.com>
@alexarice
Copy link
Collaborator Author

Apparently mlir uses properties when it says it's using attributes and so I've switched this over and am rerequesting review

@superlopuh
Copy link
Member

Yeah I've found this really confusing, I think it's because no-one's responsible for finishing the properties transition, and because attributes can be put in properties...

@alexarice alexarice merged commit 01d5b81 into main Sep 16, 2024
14 checks passed
@alexarice alexarice deleted the alexarice/switch branch September 16, 2024 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dialects Changes on the dialects testing PRs that modify tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants