-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
dialects: (cf) add switch #3156
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3156 +/- ##
==========================================
+ Coverage 90.00% 90.02% +0.01%
==========================================
Files 427 430 +3
Lines 53857 54119 +262
Branches 8344 8378 +34
==========================================
+ Hits 48474 48720 +246
- Misses 4036 4043 +7
- Partials 1347 1356 +9 ☔ View full report in Codecov by Sentry. |
Co-authored-by: Sasha Lopoukhine <superlopuh@gmail.com>
Apparently mlir uses properties when it says it's using attributes and so I've switched this over and am rerequesting review |
Yeah I've found this really confusing, I think it's because no-one's responsible for finishing the properties transition, and because attributes can be put in properties... |
Adds
cf.switch
and simple test