dialects: (scf) fix scf.if printing bug
#3160
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3160 +/- ##
==========================================
- Coverage 90.00% 90.00% -0.01%
==========================================
Files 427 427
Lines 53860 53860
Branches 8344 8344
==========================================
- Hits 48477 48476 -1
- Misses 4036 4037 +1
Partials 1347 1347 ☔ View full report in Codecov by Sentry. |
AntonLydike
approved these changes
Sep 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Didn't catch this on the original PR as the bug is crazy and filecheck isn't checking whole lines. Apparently functions in python cast to true.
Should we enforce matching on whole lines in the
scf_ops.mlirfilecheck test?