Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

transformations: Add new csl-wrapper-hoist-buffers pass #3165

Merged
merged 3 commits into from
Sep 13, 2024

Conversation

n-io
Copy link
Collaborator

@n-io n-io commented Sep 13, 2024

Adds a new pass to hoist buffer allocations to the program_module-level of csl-wrapper.

This is done in a separate pass to allow executing it at the right point in the pipeline.

@n-io n-io self-assigned this Sep 13, 2024
@n-io n-io added the transformations Changes or adds a transformatio label Sep 13, 2024
Copy link

codecov bot commented Sep 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.01%. Comparing base (303e414) to head (ddfa2f0).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3165   +/-   ##
=======================================
  Coverage   90.00%   90.01%           
=======================================
  Files         428      429    +1     
  Lines       53892    53922   +30     
  Branches     8346     8350    +4     
=======================================
+ Hits        48508    48539   +31     
  Misses       4037     4037           
+ Partials     1347     1346    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@dk949 dk949 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great stuff, just a few minor questions. Cheers

xdsl/transforms/csl_wrapper_hoist_buffers.py Outdated Show resolved Hide resolved
xdsl/transforms/csl_wrapper_hoist_buffers.py Show resolved Hide resolved
@n-io n-io requested a review from dk949 September 13, 2024 14:24
Copy link
Collaborator

@dk949 dk949 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@n-io n-io merged commit fd7e3ae into main Sep 13, 2024
13 of 14 checks passed
@n-io n-io deleted the nicolai/csl-hoist-memrefs branch September 13, 2024 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
transformations Changes or adds a transformatio
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants