transformations: (scf-to-cf) add lowering for index_switch #3179
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexarice
added
testing
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3179 +/- ##
==========================================
+ Coverage 90.03% 90.04% +0.01%
==========================================
Files 430 432 +2
Lines 54183 54483 +300
Branches 8392 8453 +61
==========================================
+ Hits 48784 49060 +276
- Misses 4043 4056 +13
- Partials 1356 1367 +11 ☔ View full report in Codecov by Sentry. |
superlopuh
reviewed
Sep 18, 2024
superlopuh
reviewed
Sep 18, 2024
| case_value, | ||
| default_block, | ||
| (), | ||
| DenseIntOrFPElementsAttr.vector_from_list(case_values, i32), |
There was a problem hiding this comment.
can this not be the op.cases above? Does the type change?
There was a problem hiding this comment.
Yes, op.cases is a DenseArrayBase but this is a DenseIntOrFPElementsAttr and these appear to not be the same
superlopuh
reviewed
Sep 18, 2024
Co-authored-by: Sasha Lopoukhine <superlopuh@gmail.com>
superlopuh
approved these changes
Sep 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Again this is mainly copied from the implementation in mlir