dialect: (csl) Adds variables to the dialect #3183
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Variables work very much like `memref.global`, but they are scalars.
|
This is a little rough around the edges (no docstrings, minimal verification). I'll clean it up if we're happy with the general concept |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3183 +/- ##
==========================================
- Coverage 90.02% 90.02% -0.01%
==========================================
Files 430 431 +1
Lines 54003 54258 +255
Branches 8353 8404 +51
==========================================
+ Hits 48617 48845 +228
- Misses 4038 4055 +17
- Partials 1348 1358 +10 ☔ View full report in Codecov by Sentry. |
From the former get_var and update_var respectively.
dk949
added a commit
that referenced
this pull request
Sep 18, 2024
* docstrings * verifications * `get_element_type` in `VariableOp` These are fixes which should have been in #3183
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Variables work very much like
memref.global, but they are scalars.Ops:
csl.variable: declare variable with optional default valuecsl.get_var: get SSA value (constant) of the variablecsl.update_varset variable from ssa valueTypes:
csl.var<T>: type of a variable