Added initial eqsat front end pass #3186
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## jianyi/eqsat/fix-ci #3186 +/- ##
=====================================================
Coverage 90.03% 90.04%
=====================================================
Files 430 433 +3
Lines 54067 54352 +285
Branches 8367 8412 +45
=====================================================
+ Hits 48681 48939 +258
- Misses 4038 4052 +14
- Partials 1348 1361 +13 ☔ View full report in Codecov by Sentry. |
superlopuh
reviewed
Sep 17, 2024
xdsl/tools/command_line_tool.py
Outdated
| @@ -405,6 +405,11 @@ def get_stencil_bufferize(): | |||
|
|
|||
| return stencil_bufferize.StencilBufferize | |||
|
|
|||
| def get_create_eclasses(): | |||
There was a problem hiding this comment.
Suggested change
| def get_create_eclasses(): | |
| def get_eqsat_create_eclasses(): |
superlopuh
reviewed
Sep 17, 2024
superlopuh
reviewed
Sep 17, 2024
Comment on lines
+29
to
+30
| # TODO: do we need a `replace_by_except` function, e.g. | ||
| # eclass_op.result.replace_by_except(eclass_op.results[0], [eclass_op.result]) |
There was a problem hiding this comment.
I'm not sure what MLIR has for this, but this works ok, no?
There was a problem hiding this comment.
I am thinking of replaceUsesWithIf(): https://mlir.llvm.org/doxygen/classmlir_1_1Operation.html#a6f5567fd62feeaf0cbba4877732c512a
There was a problem hiding this comment.
Oh that's neat, we could probably use the same helper. Could you please file an issue for this?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses #3170:
eqsat-create-eclassesfor the minimal example