dialects: (tosa) turn attributes into properties

[jorendumoulin]

The attributes are actually properties in tosa.
I got fooled by the ParsePropInAttrDict ☹️

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.02%. Comparing base (c9c6df3) to head (0d7eae3).
Report is 1 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #3188   +/-   ##
=======================================
  Coverage   90.02%   90.02%           
=======================================
  Files         431      431           
  Lines       54258    54259    +1     
  Branches     8404     8404           
=======================================
+ Hits        48845    48848    +3     
+ Misses       4055     4054    -1     
+ Partials     1358     1357    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[superlopuh]

This makes me think that it's probably worth adding a roundtrip test with MLIR to make sure we're consistent

[jorendumoulin]

That's the funny thing, there are mlir interop tests, however, as most interop tests, I only used it with custom printing. The check thus didn't notice a difference between attributes or properties that are custom printed as attributes.

Does it make sense to change

// RUN: xdsl-opt %s | xdsl-opt | mlir-opt | filecheck %s

Into

// RUN: xdsl-opt %s | xdsl-opt --print-op-generic | mlir-opt --mlir-print-op-generic | xdsl-opt | mlir-opt | filecheck %s

?

[superlopuh]

Oh interesting. Yeah maybe we should have both indeed, I doubt it will have a significant overhead in time