Feature arith dialect & Vector fix #32
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
math-fehr
reviewed
Dec 29, 2021
webmiche
reviewed
Dec 30, 2021
|
Besides the last comment, this is perfect for me! |
|
@math-fehr I added a minor parser fix to this PR as I need it for the next xdsl release. |
Dinistro
force-pushed
the
feature_arith_dialect
branch
from
c944a71 to
4512467
Compare
|
@math-fehr I would suggest that we merge this an release a new version of xdsl. Afterwards we can fix the minor breaking changes in https://github.com/compiling-techniques/ChocoPyCompiler/tree/update-xdsl |
webmiche
approved these changes
Jan 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR splits the std dialect into std and arith. To ensure that this reflects the structure of MLIR, I played around with the MLIR converter and discovered a minor flaw there. As I prefer at least partially tested code, I fixed the issue with the
VectorAttrvs.DenseElementAttras well.fixes #31 fixes #29
As a next step, we have to adapt the ChocoPy project for these changes, furthermore, I would like to have a proper tool that encapsulates the converter.