Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: Print csl namehint fix #3207

Merged
merged 1 commit into from
Sep 23, 2024
Merged

bug: Print csl namehint fix #3207

merged 1 commit into from
Sep 23, 2024

Conversation

n-io
Copy link
Collaborator

@n-io n-io commented Sep 23, 2024

Print via _use_var instead of name_hint, as that can be None.

@n-io n-io added bug Something isn't working minor For minor PRs, easy and quick to review, quickly mergeable labels Sep 23, 2024
@n-io n-io requested a review from dk949 September 23, 2024 13:14
@n-io n-io self-assigned this Sep 23, 2024
Copy link

codecov bot commented Sep 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.04%. Comparing base (5d9837e) to head (95b33cf).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3207   +/-   ##
=======================================
  Coverage   90.04%   90.04%           
=======================================
  Files         432      432           
  Lines       54454    54454           
  Branches     8448     8448           
=======================================
  Hits        49031    49031           
  Misses       4056     4056           
  Partials     1367     1367           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@dk949 dk949 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good AFAICT

@n-io n-io marked this pull request as ready for review September 23, 2024 13:56
@n-io n-io merged commit b9620a2 into main Sep 23, 2024
13 checks passed
@n-io n-io deleted the nicolai/csl-namehint-print-fix branch September 23, 2024 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working minor For minor PRs, easy and quick to review, quickly mergeable
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants