-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: (csl) adjusted width and height of the PE #3209
Conversation
They need to be 2 greater than the dmp topology
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3209 +/- ##
=======================================
Coverage 90.03% 90.04%
=======================================
Files 433 433
Lines 54568 54568
Branches 8465 8465
=======================================
+ Hits 49133 49135 +2
+ Misses 4061 4060 -1
+ Partials 1374 1373 -1 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it's better not to hard-code this, though if we want a simple fix, we can adjust width and height by adding 2*(pattern-1)
, which I believe is 2*max_distance
. Best done outside the loop.
👍 Sounds good. |
…project/xdsl into david/csl-transforms/dimensions-fix
They need to be 2 greater than the dmp topology
@n-io Could you please let me know if this looks right?