dialects: (cf) Assert canonicalization pattern #3228
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexarice
added
dialects
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3228 +/- ##
==========================================
- Coverage 90.05% 90.05% -0.01%
==========================================
Files 435 436 +1
Lines 54650 54672 +22
Branches 8474 8477 +3
==========================================
+ Hits 49217 49234 +17
- Misses 4060 4063 +3
- Partials 1373 1375 +2 ☔ View full report in Codecov by Sentry. |
superlopuh
approved these changes
Sep 30, 2024
emmau678
pushed a commit
that referenced
this pull request
Oct 8, 2024
Adds canonicalization pattern for `cf.assert` which removes "assert true"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Going to work through adding all the canonicalization patterns for the cf ops that are in mlir.
Starting with removing "assert true"