Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dialects: (riscv) canonicalization pattern added (x|0=x) #3230

Merged
merged 4 commits into from
Oct 1, 2024

Conversation

lfrenot
Copy link
Collaborator

@lfrenot lfrenot commented Oct 1, 2024

Added a riscv canonicalization pattern for bitwise or with 0.

Copy link

codecov bot commented Oct 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.07%. Comparing base (6726d0f) to head (8ad804e).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3230   +/-   ##
=======================================
  Coverage   90.07%   90.07%           
=======================================
  Files         437      437           
  Lines       54844    54859   +15     
  Branches     8518     8520    +2     
=======================================
+ Hits        49402    49416   +14     
  Misses       4062     4062           
- Partials     1380     1381    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@superlopuh superlopuh self-requested a review October 1, 2024 15:53
@superlopuh superlopuh added the dialects Changes on the dialects label Oct 1, 2024
@superlopuh
Copy link
Member

Can you please also change the GETTING_STARTED.md document to remove the suggestion of this rewrite pattern, and maybe add one of your own for the next person?

lfrenot and others added 2 commits October 1, 2024 17:01
Copy link
Member

@superlopuh superlopuh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙏

@superlopuh
Copy link
Member

Feel free to merge whenever

@lfrenot lfrenot merged commit 6b954c1 into xdslproject:main Oct 1, 2024
14 checks passed
emmau678 pushed a commit that referenced this pull request Oct 8, 2024
Added a riscv canonicalization pattern for bitwise or with 0.

---------

Co-authored-by: Sasha Lopoukhine <superlopuh@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dialects Changes on the dialects
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants