dialects: (dmp) Emit multiple swaps if halo is larger than core size #3238
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3238 +/- ##
==========================================
+ Coverage 89.90% 89.91% +0.01%
==========================================
Files 440 440
Lines 55344 55376 +32
Branches 8635 8639 +4
==========================================
+ Hits 49756 49792 +36
+ Misses 4160 4157 -3
+ Partials 1428 1427 -1 ☔ View full report in Codecov by Sentry. |
n-io
approved these changes
Oct 3, 2024
dk949
approved these changes
Oct 3, 2024
AntonLydike
deleted the
anton/fix-dmp-swap-not-considering-neighbors-field-size
branch
emmau678
pushed a commit
that referenced
this pull request
Oct 8, 2024
…3238) DMP dialect used to not consider what happens when `core_size < halo_size`. This should generate exchanges to further neighbors, instead of requesting more data from the direct neighbor than it actually holds. This is now fixed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DMP dialect used to not consider what happens when
core_size < halo_size. This should generate exchanges to further neighbors, instead of requesting more data from the direct neighbor than it actually holds.This is now fixed.