dialects: (stencil) add StencilType constraints #3254
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
superlopuh
commented
Oct 7, 2024
superlopuh
commented
Oct 7, 2024
Comment on lines
+90
to
+93
| stencil.StencilTypeConstr, | ||
| ) and isattr( | ||
| el_type := field_t.element_type, | ||
| AnyTensorTypeConstr | AnyMemRefTypeConstr, |
There was a problem hiding this comment.
this is the only kind of functional change, splitting the check into two, it should still be equivalent
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3254 +/- ##
=======================================
Coverage 89.92% 89.92%
=======================================
Files 441 441
Lines 55420 55430 +10
Branches 8643 8644 +1
=======================================
+ Hits 49835 49846 +11
Misses 4158 4158
+ Partials 1427 1426 -1 ☔ View full report in Codecov by Sentry. |
superlopuh
changed the title
math-fehr
approved these changes
Oct 8, 2024
n-io
approved these changes
Oct 8, 2024
emmau678
pushed a commit
that referenced
this pull request
Oct 8, 2024
This adds some constraint constants and a new `.constr` helper to construct parametrized constraints for stencil types. Pyright errors 143 -> 133
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds some constraint constants and a new
.constrhelper to construct parametrized constraints for stencil types. Pyright errors 143 -> 133