misc: miscellaneous linting wrt Pylance #3262
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
superlopuh
commented
Oct 8, 2024
Comment on lines
+243
to
+245
| type(cls), # pyright: ignore[reportUnknownArgumentType] | ||
| cls.__name__, | ||
| (cls,), # pyright: ignore[reportUnknownArgumentType] |
There was a problem hiding this comment.
these ignores are only needed for our pyright, the new one is happy with this, I'll do a pass to remove them with the automated "unnecessary ignores as errors" option
superlopuh
commented
Oct 8, 2024
Comment on lines
-696
to
-703
| def verify(self) -> None: | ||
| for idx, val in enumerate(self.data): | ||
| if not isinstance(val, Attribute): | ||
| raise VerifyException( | ||
| f"{self.name} data expects attribute list, but element " | ||
| f"{idx} is of type {type(val)}." | ||
| ) | ||
|
|
There was a problem hiding this comment.
The type system already enforces this, surely we don't need to check this again? Pylance now complains
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3262 +/- ##
==========================================
+ Coverage 89.92% 89.93% +0.01%
==========================================
Files 442 442
Lines 55490 55480 -10
Branches 8656 8651 -5
==========================================
- Hits 49899 49897 -2
+ Misses 4161 4157 -4
+ Partials 1430 1426 -4 ☔ View full report in Codecov by Sentry. |
alexarice
approved these changes
Oct 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Another small step towards updating Pyright, contains small changes that both our current Pyright and the new one are happy with. Pylance errors: 109 -> 94