misc: add pyright ignores for places where it's not going to be happy #3263
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3263 +/- ##
=======================================
Coverage 89.94% 89.94%
=======================================
Files 443 443
Lines 55559 55557 -2
Branches 8673 8673
=======================================
Hits 49973 49973
+ Misses 4158 4156 -2
Partials 1428 1428 ☔ View full report in Codecov by Sentry. |
math-fehr
approved these changes
Oct 9, 2024
|
|
||
| assert not isa(1, Literal["1"]) | ||
| assert not isa("1", Literal[1]) | ||
| assert isa("string", Literal["string"]) # pyright: ignore[reportArgumentType] |
There was a problem hiding this comment.
Is it the error that Literal is a TypeExpr and not a type?
xdsl/tools/tblgen_to_py.py
Outdated
| @@ -474,7 +474,7 @@ def generate_op(self, tblgen_op: TblgenOp, dialect_name: str): | |||
| fields[name] = "var_region_def()" | |||
| case (True, True): | |||
| fields[name] = 'var_region_def("single_block")' | |||
| case _: | |||
| case _: # pyright: ignore[reportUnnecessaryComparison] | |||
There was a problem hiding this comment.
Wait, should we just remove the default case then? We had this just because pyright wasn't happy, but now it is
There was a problem hiding this comment.
Yep I'll remove the default case with the new pyright, the old one still wants it. I guess I could remove it now and ignore the pyright error on the match case directly, I'll do that quickly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pyright used to be happy to accept type expressions as types, but is happy no longer. This adds the required pyright ignores to work around this restriction.
Pylance errors: 94 -> 81