Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add extension to filename when calling set_tile_code #3268

Merged
merged 1 commit into from
Oct 9, 2024

Conversation

dk949
Copy link
Collaborator

@dk949 dk949 commented Oct 9, 2024

When directly invoking cslc, the .csl file extension is not required, but when compiling with the SDK it is.

@dk949 dk949 added minor For minor PRs, easy and quick to review, quickly mergeable transformations Changes or adds a transformatio labels Oct 9, 2024
@dk949 dk949 requested review from AntonLydike and n-io October 9, 2024 12:03
@dk949 dk949 self-assigned this Oct 9, 2024
Copy link

codecov bot commented Oct 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.00%. Comparing base (27bd5c4) to head (3dbd569).
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3268      +/-   ##
==========================================
+ Coverage   89.94%   90.00%   +0.05%     
==========================================
  Files         443      443              
  Lines       55559    55559              
  Branches     8673     5344    -3329     
==========================================
+ Hits        49973    50005      +32     
  Misses       4158     4158              
+ Partials     1428     1396      -32     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dk949 dk949 merged commit 9910901 into main Oct 9, 2024
14 checks passed
@dk949 dk949 deleted the david/csl-transforms/file-name-fix branch October 9, 2024 12:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
minor For minor PRs, easy and quick to review, quickly mergeable transformations Changes or adds a transformatio
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants