-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
transformations: (lower-csl-stencil) Optimise full-stencil access #3271
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3271 +/- ##
==========================================
+ Coverage 89.92% 89.98% +0.05%
==========================================
Files 442 444 +2
Lines 55489 55688 +199
Branches 8656 5362 -3294
==========================================
+ Hits 49899 50110 +211
- Misses 4161 4172 +11
+ Partials 1429 1406 -23 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How does this pass interact with the "Option 3" method that used to be emitted?
If the optimization is performed, does Option 3 still apply?
For For |
Pretty printing for #3271 --------- Co-authored-by: n-io <n-io@users.noreply.github.com>
For full-stencil accesses followed by an immediate reduction of a uniform reduction function, use the catch-all
getRecvBufDsd
API call instead of the neighbour-by-neighbourgetRecvBufDsdByNeighbor
function.Iff this optimisation is applicable, the accumulator dsd might look like this:
This is currently implemented by setting the strides of
i
andj
to 0, which might require a printer update (tbc).