dialects (arith) add fastmath option for float comparisons #3272
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3272 +/- ##
=======================================
Coverage ? 89.97%
=======================================
Files ? 444
Lines ? 55633
Branches ? 5357
=======================================
Hits ? 50055
Misses ? 4177
Partials ? 1401 ☔ View full report in Codecov by Sentry. |
|
This is great! Could you please split this into three PRs: arith, riscv, and lowering? |
|
The code pretty much looks ready to merge, but it would be good to add some filecheck tests for the custom format for each of the dialect PRs. |
|
@superlopuh I will attempt to split it up. Can you explain |
This was referenced Oct 10, 2024
|
The split is great, exactly what I meant, thank you |
superlopuh
added a commit
that referenced
this pull request
Oct 23, 2024
EdmundGoodman
pushed a commit
to EdmundGoodman/xdsl
that referenced
this pull request
Dec 6, 2024
…ons (xdslproject#3276) `riscv`-only part of xdslproject#3272, with a new dialect test added. Thanks for the suggestion of separate tests, I didn't realize those existed and caught an error in the LiOp implementation while adding the test cases.
EdmundGoodman
pushed a commit
to EdmundGoodman/xdsl
that referenced
this pull request
Dec 6, 2024
`backend`(lowering)-only part of xdslproject#3272. Depends on xdslproject#3275 and xdslproject#3276. This should close xdslproject#2725 once merged Co-authored-by: Sasha Lopoukhine <superlopuh@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add an optional fastmath attribute to
arith.cmpfand include the attribute while lowering to riscvHopefully closes #2725.