dialects: (cf) cond_br folding #3283
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexarice
added
dialects
alexarice
commented
Oct 10, 2024
| @@ -9,6 +9,7 @@ | |||
| op_type_rewrite_pattern, | |||
| ) | |||
| from xdsl.rewriter import InsertPoint | |||
| from xdsl.transforms.canonicalization_patterns.scf import const_evaluate_operand | |||
There was a problem hiding this comment.
Should this be moved somewhere else, and if so where?
There was a problem hiding this comment.
xdsl.transforms.canonicalization_patterns.utils? Can then be moved up as needed
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3283 +/- ##
=======================================
Coverage 89.98% 89.99%
=======================================
Files 444 445 +1
Lines 55639 55719 +80
Branches 5354 5367 +13
=======================================
+ Hits 50068 50142 +74
+ Misses 4174 4171 -3
- Partials 1397 1406 +9 ☔ View full report in Codecov by Sentry. |
superlopuh
approved these changes
Oct 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First two
cond_brcanonicalization patterns:cf.cond_br %true ^0 ^1==cf.br ^0)brop gets forwarded)