Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

transformations: (cf) cf.cond_br truth propagation #3285

Merged
merged 1 commit into from
Oct 15, 2024

Conversation

alexarice
Copy link
Collaborator

Truth propagation canonicalization pattern.

I have not implemented the SimplifyCondBranchFromCondBranchOnSameCondition pattern from mlir, because it seems to be implied from this pattern and previous const folding pattern.

@alexarice alexarice added dialects Changes on the dialects transformations Changes or adds a transformatio labels Oct 10, 2024
@alexarice alexarice requested a review from superlopuh October 10, 2024 15:10
@alexarice alexarice self-assigned this Oct 10, 2024
Copy link

codecov bot commented Oct 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.01%. Comparing base (f0a74f1) to head (917edbc).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3285   +/-   ##
=======================================
  Coverage   90.01%   90.01%           
=======================================
  Files         445      445           
  Lines       55940    55956   +16     
  Branches     5360     5364    +4     
=======================================
+ Hits        50354    50370   +16     
+ Misses       4178     4177    -1     
- Partials     1408     1409    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@alexarice alexarice force-pushed the alexarice/cond_br_more_canonicalize branch from bc3a18e to 5aae212 Compare October 10, 2024 15:36
@alexarice alexarice force-pushed the alexarice/cond_br_most_canonicalize branch from 2fdf81d to 7847fad Compare October 10, 2024 15:36
Base automatically changed from alexarice/cond_br_more_canonicalize to main October 15, 2024 12:52
@alexarice alexarice force-pushed the alexarice/cond_br_most_canonicalize branch from 7847fad to 917edbc Compare October 15, 2024 12:58
@alexarice alexarice merged commit b452684 into main Oct 15, 2024
14 checks passed
@alexarice alexarice deleted the alexarice/cond_br_most_canonicalize branch October 15, 2024 13:17
EdmundGoodman pushed a commit to EdmundGoodman/xdsl that referenced this pull request Dec 6, 2024
Truth propagation canonicalization pattern.

I have not implemented the
`SimplifyCondBranchFromCondBranchOnSameCondition` pattern from mlir,
because it seems to be implied from this pattern and previous const
folding pattern.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dialects Changes on the dialects transformations Changes or adds a transformatio
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants