Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

misc: remove unnecessary pyright ignore comments [NFC] #3286

Merged
merged 2 commits into from
Oct 11, 2024

Conversation

superlopuh
Copy link
Member

I added reportUnnecessaryTypeIgnoreComment = true to pyproject.toml to find these

@superlopuh superlopuh added the misc Miscellaneous label Oct 10, 2024
@superlopuh superlopuh self-assigned this Oct 10, 2024
@superlopuh superlopuh changed the title misc: remove unnecessary pyright ignore comments misc: remove unnecessary pyright ignore comments [NFC] Oct 10, 2024
@superlopuh superlopuh added the minor For minor PRs, easy and quick to review, quickly mergeable label Oct 10, 2024
Copy link

codecov bot commented Oct 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.99%. Comparing base (d6f787a) to head (50a5666).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3286   +/-   ##
=======================================
  Coverage   89.99%   89.99%           
=======================================
  Files         445      445           
  Lines       55749    55749           
  Branches     5367     5367           
=======================================
  Hits        50173    50173           
  Misses       4166     4166           
  Partials     1410     1410           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@math-fehr
Copy link
Collaborator

Oh that's nice! Should we keep this option in the .toml?

@alexarice
Copy link
Collaborator

I assume keeping the option on makes it difficult to support multiple python versions?

@superlopuh
Copy link
Member Author

Yeah I removed it ultimately because I have a feeling that it will make the kind of migration we just did more difficult in the future.

@superlopuh superlopuh merged commit b431115 into main Oct 11, 2024
14 checks passed
@superlopuh superlopuh deleted the sasha/misc/unnecessary-type-ignore branch October 11, 2024 08:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
minor For minor PRs, easy and quick to review, quickly mergeable misc Miscellaneous
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants