dialects: (bufferization) add materialize_in_destination #3301
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3301 +/- ##
========================================
Coverage 90.01% 90.02%
========================================
Files 445 445
Lines 55850 55979 +129
Branches 5351 5365 +14
========================================
+ Hits 50274 50393 +119
- Misses 4169 4177 +8
- Partials 1407 1409 +2 ☔ View full report in Codecov by Sentry. |
superlopuh
changed the title
superlopuh
reviewed
Oct 14, 2024
superlopuh
changed the title
superlopuh
changed the title
superlopuh
reviewed
Oct 15, 2024
superlopuh
reviewed
Oct 15, 2024
xdsl/dialects/bufferization.py
Outdated
| @@ -168,12 +168,39 @@ class ToMemrefOp(IRDLOperation): | |||
| assembly_format = "$tensor (`read_only` $read_only^)? `:` attr-dict type($memref)" | |||
|
|
|||
|
|
|||
| # now only works for (tensor, tensor) arguments. need to add memref support as well. | |||
There was a problem hiding this comment.
Suggested change
| # now only works for (tensor, tensor) arguments. need to add memref support as well. |
superlopuh
approved these changes
Oct 15, 2024
EdmundGoodman
pushed a commit
to EdmundGoodman/xdsl
that referenced
this pull request
Dec 6, 2024
…#3301) Currently we need only the command with tensor arguments but we should extend it to memrefs as well at some point.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently we need only the command with tensor arguments but we should extend it to memrefs as well at some point.