Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

transformations: Support devito timers in the csl pipeline #3312

Merged
merged 3 commits into from
Oct 17, 2024

Conversation

n-io
Copy link
Collaborator

@n-io n-io commented Oct 16, 2024

No description provided.

@n-io n-io added the transformations Changes or adds a transformatio label Oct 16, 2024
@n-io n-io self-assigned this Oct 16, 2024
Copy link

codecov bot commented Oct 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.04%. Comparing base (a171e38) to head (d1e3c2e).
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3312      +/-   ##
==========================================
- Coverage   90.04%   90.04%   -0.01%     
==========================================
  Files         445      445              
  Lines       56178    56215      +37     
  Branches     5391     5398       +7     
==========================================
+ Hits        50584    50616      +32     
- Misses       4179     4180       +1     
- Partials     1415     1419       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@n-io n-io marked this pull request as ready for review October 16, 2024 18:55
Copy link
Collaborator

@dk949 dk949 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, I'm guessing we'll never be in a situation where we have two timers (if we are, the exported names will clash)

@n-io
Copy link
Collaborator Author

n-io commented Oct 17, 2024

Looks good to me, I'm guessing we'll never be in a situation where we have two timers (if we are, the exported names will clash)

Good point, it's not actually explicitly prevented from happening. As with other exported names it also comes from the func arg name hints.

@n-io n-io merged commit 71aecc8 into main Oct 17, 2024
14 checks passed
@n-io n-io deleted the nicolai/csl-timers branch October 17, 2024 11:37
n-io added a commit that referenced this pull request Oct 17, 2024
n-io added a commit that referenced this pull request Oct 17, 2024
Co-authored-by: n-io <n-io@users.noreply.github.com>
n-io added a commit that referenced this pull request Oct 17, 2024
Co-authored-by: n-io <n-io@users.noreply.github.com>
EdmundGoodman pushed a commit to EdmundGoodman/xdsl that referenced this pull request Dec 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
transformations Changes or adds a transformatio
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants