-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
transformations: Support devito timers in the csl pipeline #3312
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3312 +/- ##
==========================================
- Coverage 90.04% 90.04% -0.01%
==========================================
Files 445 445
Lines 56178 56215 +37
Branches 5391 5398 +7
==========================================
+ Hits 50584 50616 +32
- Misses 4179 4180 +1
- Partials 1415 1419 +4 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, I'm guessing we'll never be in a situation where we have two timers (if we are, the exported names will clash)
Good point, it's not actually explicitly prevented from happening. As with other exported names it also comes from the func arg name hints. |
Co-authored-by: n-io <n-io@users.noreply.github.com>
Co-authored-by: n-io <n-io@users.noreply.github.com>
…ct#3312) Co-authored-by: n-io <n-io@users.noreply.github.com>
No description provided.