core: relax some types in range variable solving #3317
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3317 +/- ##
=======================================
Coverage 90.04% 90.04%
=======================================
Files 445 445
Lines 56182 56182
Branches 5391 5391
=======================================
Hits 50588 50588
Misses 4179 4179
Partials 1415 1415 ☔ View full report in Codecov by Sentry. |
superlopuh
approved these changes
Oct 18, 2024
math-fehr
approved these changes
Oct 18, 2024
EdmundGoodman
pushed a commit
to EdmundGoodman/xdsl
that referenced
this pull request
Dec 6, 2024
Relaxes some of the assertions for range variable solving. This allows a range variable to resolve to any sequence (i.e. a tuple) instead of just a list.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relaxes some of the assertions for range variable solving. This allows a range variable to resolve to any sequence (i.e. a tuple) instead of just a list.