transformations: (lower-csl-wrapper) Add params_as_consts flag #3324
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
n-io
added
minor
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3324 +/- ##
=======================================
Coverage 90.08% 90.08%
=======================================
Files 446 446
Lines 56419 56422 +3
Branches 5417 5419 +2
=======================================
+ Hits 50824 50829 +5
+ Misses 4162 4161 -1
+ Partials 1433 1432 -1 ☔ View full report in Codecov by Sentry. |
|
The PR does not indicate why this flag is needed and also lacks a testcase. Either add a test case or explain in the commit message why no test case can be added. |
| // CONST-NEXT: "csl.rpc"(%0) : (!csl.color) -> () | ||
| // CONST-NEXT: }) {"sym_name" = "gauss_seidel_func_program"} : () -> () | ||
| // CONST-NEXT: } | ||
| // CONST-EMPTY: |
There was a problem hiding this comment.
This test case is huge. Do we need such a large test case to test this feature? Or can there be a smaller minimal test case?
There was a problem hiding this comment.
I added a shorter test, with and without the flag. @dk949
tobiasgrosser
approved these changes
Oct 23, 2024
tobiasgrosser
approved these changes
Oct 24, 2024
EdmundGoodman
pushed a commit
to EdmundGoodman/xdsl
that referenced
this pull request
Dec 6, 2024
…roject#3324) CSL module wrapper params are by default lowered to CSL params, which can have a value specified in code that can be overridden manually by providing command line inputs. If this is not desired, module wrapper params can be lowered to constants instead by setting the `params_as_consts` flag. For this to happen, the module wrapper params must be numerical and have a specified default value. Use this flag for programs if the generated program does not support arbitrary param values. --------- Co-authored-by: n-io <n-io@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CSL module wrapper params are by default lowered to CSL params, which can have a value specified in code that can be overridden manually by providing command line inputs. If this is not desired, module wrapper params can be lowered to constants instead by setting the
params_as_constsflag. For this to happen, the module wrapper params must be numerical and have a specified default value.Use this flag for programs if the generated program does not support arbitrary param values.