transformations: (arith-to-varith) Support more cases #3330
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
n-io
added
minor
n-io
commented
Oct 22, 2024
| @@ -209,6 +200,7 @@ def apply(self, ctx: MLContext, op: builtin.ModuleOp) -> None: | |||
| MergeVarithOpsPattern(), | |||
| ] | |||
| ), | |||
| walk_reverse=True, | |||
There was a problem hiding this comment.
This is needed to ensure all ops are folded away.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3330 +/- ##
==========================================
- Coverage 90.04% 90.04% -0.01%
==========================================
Files 446 446
Lines 56330 56327 -3
Branches 5405 5403 -2
==========================================
- Hits 50720 50717 -3
Misses 4183 4183
Partials 1427 1427 ☔ View full report in Codecov by Sentry. |
emmau678
reviewed
Oct 22, 2024
tobiasgrosser
approved these changes
Oct 23, 2024
EdmundGoodman
pushed a commit
to EdmundGoodman/xdsl
that referenced
this pull request
Dec 6, 2024
In some edge-cases a single arith op was not folded away. This should be fixed now. --------- Co-authored-by: n-io <n-io@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In some edge-cases a single arith op was not folded away. This should be fixed now.