Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dialects: (varith) fix switch parsing #3351

Merged
merged 1 commit into from
Oct 29, 2024
Merged

Conversation

alexarice
Copy link
Collaborator

Apparently putting generic syntax in a roundtrip test never tests the parsing.
Should have listened to @superlopuh

@alexarice alexarice added bug Something isn't working dialects Changes on the dialects labels Oct 29, 2024
@alexarice alexarice self-assigned this Oct 29, 2024
Copy link

codecov bot commented Oct 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.10%. Comparing base (21b6a60) to head (4a1b2e2).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3351      +/-   ##
==========================================
+ Coverage   90.06%   90.10%   +0.03%     
==========================================
  Files         447      447              
  Lines       56532    56533       +1     
  Branches     5425     5425              
==========================================
+ Hits        50915    50938      +23     
+ Misses       4184     4162      -22     
  Partials     1433     1433              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@alexarice alexarice merged commit c556a6a into main Oct 29, 2024
14 checks passed
@alexarice alexarice deleted the alexarice/var-select-fix branch October 29, 2024 16:11
EdmundGoodman pushed a commit to EdmundGoodman/xdsl that referenced this pull request Dec 6, 2024
Apparently putting generic syntax in a roundtrip test never tests the
parsing.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working dialects Changes on the dialects
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants