fix: (csl) Use u32 as the counter in async loops
#3353
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, `i16` was used, this significantly limited the maximum loop iterations.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3353 +/- ##
=======================================
Coverage ? 90.09%
=======================================
Files ? 447
Lines ? 56578
Branches ? 5431
=======================================
Hits ? 50975
Misses ? 4166
Partials ? 1437 ☔ View full report in Codecov by Sentry. |
n-io
reviewed
Oct 29, 2024
The runtime I get when running for ~30000 iterations is extremely low, on the order of 10ms, having the ability to bump it higher would let us do longer runs. Is there any benefit to |
|
Would you expect there to be any performance implications? |
|
Not from reading the docs, no. |
n-io
approved these changes
Oct 30, 2024
EdmundGoodman
pushed a commit
to EdmundGoodman/xdsl
that referenced
this pull request
Dec 6, 2024
Previously, `i16` was used, this significantly limited the maximum loop iterations.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously,
i16was used, this significantly limited the maximum loop iterations.