core: Print FloatAttr special values #3377
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3377 +/- ##
==========================================
+ Coverage 90.12% 90.13% +0.01%
==========================================
Files 452 452
Lines 57098 57134 +36
Branches 5491 5493 +2
==========================================
+ Hits 51459 51499 +40
+ Misses 4183 4180 -3
+ Partials 1456 1455 -1 ☔ View full report in Codecov by Sentry. |
alexarice
reviewed
Nov 1, 2024
superlopuh
requested changes
Nov 1, 2024
superlopuh
reviewed
Nov 1, 2024
superlopuh
reviewed
Nov 1, 2024
n-io
commented
Nov 1, 2024
superlopuh
reviewed
Nov 2, 2024
Co-authored-by: Sasha Lopoukhine <superlopuh@gmail.com>
superlopuh
reviewed
Nov 3, 2024
xdsl/printer.py
Outdated
Comment on lines
541
to
552
| if isinstance(attr_type, Float16Type): | ||
| self.print_string( | ||
| f"{hex(struct.unpack('<H', struct.pack('<e', value.data))[0])} : " | ||
| ) | ||
| elif isinstance(attr_type, Float32Type): | ||
| self.print_string( | ||
| f"{hex(struct.unpack('<I', struct.pack('<f', value.data))[0])} : " | ||
| ) | ||
| elif isinstance(attr_type, Float64Type): | ||
| self.print_string( | ||
| f"{hex(struct.unpack('<Q', struct.pack('<d', value.data))[0])} : " | ||
| ) |
There was a problem hiding this comment.
Now that I think about it, it feels like it would be better to use the helpers in bitwise_casts after all, using the struct or ctypes approach. We will need the logic in a few places, such as when storing float data in assembly, and other optimisations, so it would be worth having it in an easily reusable place.
superlopuh
reviewed
Nov 3, 2024
|
I have added further |
n-io
added a commit
that referenced
this pull request
Nov 4, 2024
`FloatAttr`s can have their values specified by a hexadecimal literal. This should be interpreted as the bit representation of the float. However, it is currently interpreted as an int number and then converted to a float, leading to incorrect behaviour. This PR is the second part of #3370 after #3377 --------- Co-authored-by: n-io <n-io@users.noreply.github.com>
lfrenot
pushed a commit
that referenced
this pull request
Nov 4, 2024
This prints `FloatAttr` special values `nan`, `inf`, `-inf` as a hexadecimal binary representation to align with mlir-opt as described in #3370 Also see the [FloatAttr docs](https://mlir.llvm.org/docs/Dialects/Builtin/#floatattr) or give it a try on [godbolt](https://godbolt.org/z/89TfsvaKT). --------- Co-authored-by: n-io <n-io@users.noreply.github.com>
lfrenot
pushed a commit
that referenced
this pull request
Nov 4, 2024
`FloatAttr`s can have their values specified by a hexadecimal literal. This should be interpreted as the bit representation of the float. However, it is currently interpreted as an int number and then converted to a float, leading to incorrect behaviour. This PR is the second part of #3370 after #3377 --------- Co-authored-by: n-io <n-io@users.noreply.github.com>
lfrenot
pushed a commit
that referenced
this pull request
Nov 4, 2024
This prints `FloatAttr` special values `nan`, `inf`, `-inf` as a hexadecimal binary representation to align with mlir-opt as described in Also see the [FloatAttr docs](https://mlir.llvm.org/docs/Dialects/Builtin/#floatattr) or give it a try on [godbolt](https://godbolt.org/z/89TfsvaKT). --------- Co-authored-by: n-io <n-io@users.noreply.github.com>
EdmundGoodman
pushed a commit
to EdmundGoodman/xdsl
that referenced
this pull request
Dec 6, 2024
This prints `FloatAttr` special values `nan`, `inf`, `-inf` as a hexadecimal binary representation to align with mlir-opt as described in xdslproject#3370 Also see the [FloatAttr docs](https://mlir.llvm.org/docs/Dialects/Builtin/#floatattr) or give it a try on [godbolt](https://godbolt.org/z/89TfsvaKT). --------- Co-authored-by: n-io <n-io@users.noreply.github.com>
EdmundGoodman
pushed a commit
to EdmundGoodman/xdsl
that referenced
this pull request
Dec 6, 2024
…t#3378) `FloatAttr`s can have their values specified by a hexadecimal literal. This should be interpreted as the bit representation of the float. However, it is currently interpreted as an int number and then converted to a float, leading to incorrect behaviour. This PR is the second part of xdslproject#3370 after xdslproject#3377 --------- Co-authored-by: n-io <n-io@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This prints
FloatAttrspecial valuesnan,inf,-infas a hexadecimal binary representation to align with mlir-opt as described in #3370Also see the FloatAttr docs or give it a try on godbolt.