dialects: (ptr) Introducing ptr dialect #3380
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3380 +/- ##
==========================================
+ Coverage 90.10% 90.13% +0.02%
==========================================
Files 450 451 +1
Lines 56796 56868 +72
Branches 5459 5459
==========================================
+ Hits 51178 51256 +78
+ Misses 4176 4167 -9
- Partials 1442 1445 +3 ☔ View full report in Codecov by Sentry. |
superlopuh
reviewed
Nov 2, 2024
superlopuh
reviewed
Nov 2, 2024
| @@ -0,0 +1,20 @@ | |||
| // RUN: xdsl-opt %s --parsing-diagnostics --verify-diagnostics --split-input-file | filecheck %s | |||
|
|
|||
| builtin.module { | |||
There was a problem hiding this comment.
Suggested change
| builtin.module { |
superlopuh
reviewed
Nov 2, 2024
superlopuh
reviewed
Nov 2, 2024
xdsl/dialects/ptr.py
Outdated
Comment on lines
48
to
49
| elem_type = prop_def(base(Attribute)) | ||
| offset = result_def(AnyOf([IntegerType, IndexType])) |
There was a problem hiding this comment.
Suggested change
| elem_type = prop_def(base(Attribute)) | |
| offset = result_def(AnyOf([IntegerType, IndexType])) | |
| elem_type = prop_def() | |
| offset = result_def(IntegerAttrTypeConstr) |
There was a problem hiding this comment.
prop_def complains that it needs a constraint parameter
superlopuh
reviewed
Nov 2, 2024
superlopuh
reviewed
Nov 2, 2024
superlopuh
reviewed
Nov 2, 2024
xdsl/dialects/ptr.py
Outdated
| class TypeOffsetOp(IRDLOperation): | ||
| name = "ptr_xdsl.type_offset" | ||
|
|
||
| elem_type = prop_def(base(Attribute)) |
There was a problem hiding this comment.
Suggested change
| elem_type = prop_def(base(Attribute)) | |
| elem_type = prop_def(Attribute) |
You're right, I didn't realise that prop_def needed a constraint. Also AnyAttr() would work here.
superlopuh
approved these changes
Nov 2, 2024
EdmundGoodman
pushed a commit
to EdmundGoodman/xdsl
that referenced
this pull request
Dec 6, 2024
Porting the ptr dialect proposed [here](https://discourse.llvm.org/t/rfc-ptr-dialect-modularizing-ptr-ops-in-the-llvm-dialect/75142/21). Going to transfer the riscv compilation pipeline to it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Porting the ptr dialect proposed here. Going to transfer the riscv compilation pipeline to it.